Use opentype.js to test font data

fontello / svg2ttf

SVG -> TTF font convertor

MIT License

518 stars 79 forks source link

Use opentype.js to test font data #102

Closed yisibl closed 3 years ago

yisibl commented 3 years ago

Through this PR, we can better test fonts and no longer use binary-based comparison methods.

This PR incidentally fixes all options must remove extra white space.
This will help improve the https://github.com/fontello/svg2ttf/pull/86 test.

yisibl commented 3 years ago

@puzrin PTAL.

yisibl commented 3 years ago

@puzrin We really need to test based on the font table, I recently upgraded from v2.0.0 to the latest version and there were a lot of problems. Without these tests, it is difficult to troubleshoot and find problems.

yisibl commented 3 years ago

Sorry, please let me test in the fork's svg2ttf-new first. I need to solve the problem of line-height in Windows first(https://github.com/fontello/svg2ttf/issues/105). Later, I will deploy to our product to test, if there is no problem, I will clean up this PR.

puzrin commented 3 years ago

@yisibl see master updates. IMO this PR has no more worth to merge.

yisibl commented 3 years ago

@yisibl see master updates. IMO this PR has no more worth to merge.

I can resubmit a new PR.

puzrin commented 3 years ago

@yisibl if you think something important was missed in master commits - please do PR, i will review.

puzrin commented 3 years ago

IMO master is ready for release, but i'll be waiting for your comments for sure.