search

fontello / svg2ttf

SVG -> TTF font convertor
MIT License
518 stars 79 forks source link

Install the xmldom package from Github instead of NPM #118

Closed mzabuawala closed 3 years ago

mzabuawala commented 3 years ago

As xmldom 7.0 is not available on NPM repo, meanwhile we can provide a solution by allowing user to install the newer version from GitHub. Ref: fontello#116

gdomiciano commented 3 years ago

Hello, we have gotten an update from the original xmldom issue: https://github.com/xmldom/xmldom/issues/271#issuecomment-900899688

Once the new package is published this PR can be updated with the new reference instead, let's hope to get the new link in a few days :)

puzrin commented 3 years ago
  1. I don't like idea to point dependencies out of npm registry.
  2. Since severity is not significant, i see no reasons to make releases until situation with xmldom become stable.

Just let me know when xmldom will be released in registry.

gdomiciano commented 3 years ago

No one likes the idea of using dependencies out of the npm registry :)

I hope that you have read the link I posted, my suggestion was to update this PR with the new NPM package that will be created under the name @xmldom, once we get that This PR could have the update and then proceed, there was no need to close it IMHO :)

puzrin commented 3 years ago

I mean "let's do nothing until can be done well" :). IMO, problem is not critical and trivial - not worth time been spent.

karfau commented 3 years ago

FYI: The package has now been published to npm as @xmldom/xmldom so it requires manually switching.

puzrin commented 3 years ago

https://github.com/fontello/svg2ttf/commit/c15727ace1626f4504db2f160267d33ddba9194a

@karfau thanks for notification