fontello / svg2ttf

SVG -> TTF font convertor
MIT License
521 stars 79 forks source link

Minor typo in ttf/tables/name.js #22

Closed tshinnic closed 10 years ago

tshinnic commented 10 years ago

Note that currently this typo has no effect on output TTF files. Only if the getStrings() function includes more languages might this change.

An array is set up with objects that include property name "languageID". Later the array is sorted using an ordered list of property name keys. Typo is that key list contains "language" vs. the correct "languageID". Below diff fixes this. (If I get time I'll do a proper pull request).

--- name.js.original    2014-05-26 14:13:48.753995700 -0500
+++ name.js     2014-05-28 13:21:30.427525000 -0500
@@ -50,7 +50,7 @@
   });

   result.sort(function (a, b) {
-    var orderFields = ['platformID', 'encodingID', 'language', 'id'];
+    var orderFields = ['platformID', 'encodingID', 'languageID', 'id'];
     var i;
     for (i = 0; i < orderFields.length; i++) {
       if (a[orderFields[i]] !== b[orderFields[i]]) {
puzrin commented 10 years ago

Thanks for note.