Closed yisibl closed 3 years ago
@puzrin please take a look?
I'd say, project tests should be reorganized with use of opentype.js
instead of binary compare. Because everything flies to nightmare :).
Without normal testing it's very difficult to move forward.
IMO this is not enough flexible and should be reworked.
[ data, id, platformID, encodingID, languageID ]
. That will allow to add any vendor string user can imagine.--version-num
also required to define header value explicit.@yisibl here are 2 PRs and 1 issue i'd like to close/replace: #86, #102, #105.
Reason: topics were mutated multiple time, and tend to be "endless".
My last opinion https://github.com/fontello/svg2ttf/pull/86#issuecomment-846154816 is to create 2 new issues if that's still actual. AFAIK, all other critical things have been landed to master. Let me know what you think.
I'm very sorry for the late reply. When I have time, I will investigate how the APIs of other libraries are handled. You can close these issues first. Thanks!
Closed in favor of #111 & #112
The sfntNames now support more fields:
fontRevision
It is no longer always1.0
. Based on the recommendations[1] in this document, we can now support better version number settings. It can be displayed correctly in the font editing software.e.g.
Version 5.678 beta3
TODO: add test cases.
[1] https://silnrsi.github.io/FDBP/en-US/Versioning.html