fontello / svg2ttf

SVG -> TTF font convertor
MIT License
518 stars 79 forks source link

New: add more name IDs and make sure the correct settings are fontRev… #86

Closed yisibl closed 3 years ago

yisibl commented 5 years ago
  1. The sfntNames now support more fields:

    • designer
    • designerurl
    • license
    • licenseurl
  2. fontRevision It is no longer always 1.0. Based on the recommendations[1] in this document, we can now support better version number settings. It can be displayed correctly in the font editing software.

e.g. Version 5.678 beta3

FontLab VI

TODO: add test cases.

[1] https://silnrsi.github.io/FDBP/en-US/Versioning.html

yisibl commented 4 years ago

@puzrin please take a look?

puzrin commented 4 years ago

I'd say, project tests should be reorganized with use of opentype.js instead of binary compare. Because everything flies to nightmare :).

Without normal testing it's very difficult to move forward.

puzrin commented 3 years ago

IMO this is not enough flexible and should be reworked.

  1. Split for 2 parts: pure string add and version magic.
  2. Api for string add clutter options significantly. IMO this can be added via more abstract interface, list of [ data, id, platformID, encodingID, languageID ]. That will allow to add any vendor string user can imagine.
  3. I don't like existing magic with version. It can exists, to extract 2 major numbers, when possible, but --version-num also required to define header value explicit.
puzrin commented 3 years ago

@yisibl here are 2 PRs and 1 issue i'd like to close/replace: #86, #102, #105.

Reason: topics were mutated multiple time, and tend to be "endless".

My last opinion https://github.com/fontello/svg2ttf/pull/86#issuecomment-846154816 is to create 2 new issues if that's still actual. AFAIK, all other critical things have been landed to master. Let me know what you think.

yisibl commented 3 years ago

I'm very sorry for the late reply. When I have time, I will investigate how the APIs of other libraries are handled. You can close these issues first. Thanks!

puzrin commented 3 years ago

Closed in favor of #111 & #112