search

fontforge / libspiro

Spiro is the creation of Raph Levien. It simplifies the drawing of beautiful curves. (Migrated here from libspiro.sourceforge.net on 2013-04-20)
GNU General Public License v3.0
107 stars 25 forks source link

`make test` does nothing and should be removed; `make check` should be documented as "the right way to do it" #30

Closed ctrlcctrlv closed 2 years ago

ctrlcctrlv commented 4 years ago

For some reason, Makefile.am contains a reference to make test:

https://github.com/fontforge/libspiro/blob/84ce4dfd24f0e3ee83589bbfb02723dff5c03414/Makefile.am#L43-L44

This does nothing. Eventually I determined make check was the proper command; this should probably be documented. :smile:

JoesCat commented 4 years ago

This code was implemented in 2013 to avoid importing testsuite which was neither stable or usable on some platforms. Basically, it's testsuite-lite, without having to include testsuite. It is based on other code that used similar techniques (back then in 2013).

Fewer dependencies allowed libspiro to have a better chance of compiling on more platforms.

ctrlcctrlv commented 4 years ago

make check should still be documented even if make test is not removed. make test maybe should output a warning that it does nothing intentionally

JoesCat commented 4 years ago

TODO - add make check and maybe make distcheck to README/README.md

JoesCat commented 2 years ago

code removed for "make test:" done.

JoesCat commented 2 years ago

New release. Closing issue as done.