chore: bump packages - Githubissues

fontsource / google-font-metadata

A metadata generator that fetches and parses the Google Fonts API.

MIT License

29 stars 9 forks source link

chore: bump packages #131

Closed LeoDog896 closed 1 year ago

LeoDog896 commented 1 year ago

bumps all packages
drops scripts/add-hashbang.ts (https://github.com/privatenumber/pkgroll/pull/40)
fixes typo
corrects ts error

ayuhito commented 1 year ago

bumps all packages

Happy to accept this PR! One thing to note is that I'm not too keen on updating dependencies in this project anymore since nothing is broken and updating dependencies potentially can break something with no real benefit. Nor are there any security concerns due to the scope of this project. I'll still accept this change though for now.

drops scripts/add-hashbang.ts (fix(binary): add hashbang on Windows privatenumber/pkgroll#40)

IIRC, this didn't fix the bug, so I haven't removed it yet despite already updating pkgroll. I think we should revert this change, but otherwise LGTM! 🎉

LeoDog896 commented 1 year ago

Odd, pkgroll seems to be adding the shebang in Windows for me (and the CI runs tests on windows as well). I know that it doesn't add it to cli.js, but that file is also unused (also why I asked about it back in discord 😅). Absolutely understand your concerns with updating dependencies, though.

ayuhito commented 1 year ago

Sorry for the delay, I wanted to test this branch to confirm if it is working on Windows but ran into this error due to Got 13 - https://github.com/sindresorhus/got/issues/2267

pkgroll won't compile since it uses rollup-plugin-dts under the hood which needs perfect typing .^^ It might be better to roll back to Got 12 in this case.