Improve com_google_fonts_check_165 (Familyname must be unique according to namecheck.fontdata.com)

[graphicore]

Observed behaviour

• The check creates a lot of requests to namecheck.fontdata.com when used in the FB dashboard, effectively DOSing the service. see: #1680
• The check uses the wrong family name format (without spaces) and thereby produces false positives (PASSes).
• The check produces false negatives when checking fonts that are already published by us, i.e. when the family run is not for a new addition but an update.
• The worst case result is INFO thus it's likely that the check result will be ignored anyways.

Expected behaviour

• Do not DOS the service.

  • don't request once per font, but instead once per family name (this can reduce the amount of requests from 18 to 1 for big families)
  • skip when font is published (this would be a BIG reductuion in requests!)

• use familyname_with_spaces instead of familyname CAUTION: that still uses font and thus runs once per font, maybe familyname should use fonts (I'm investing if it is feasible to get an iterarg from a condition now, so familynames could be created from fonts and it would be a list of unique family names )

• skip when font is published OR change behavior to fail if font is NOT registered in namecheck service. The latter counters the attempts to reduce the number of requests, so we may NOT want to check this.

  • maybe we can have a new_family condition and run it only then! (conditions = ["not listed_on_gfonts_api"])

• should at least WARN in case of failure

[graphicore]

We're discussing having this as a column in the upstream spreadsheet, so a human checks it and signs of.

[davelab6]

https://github.com/googlefonts/namecheck/issues/1 could help with this