fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
549 stars 102 forks source link

Add check upstream for build script #1860

Open davelab6 opened 6 years ago

davelab6 commented 6 years ago

Per https://github.com/FAlthausen/Vollkorn-Typeface/issues/22 we should check upstream projects for a build script

A second check would be that it works, I guess :)

I also wonder that we could have a check that the output of fontmake equals the output of GlyphsApp, or, if the .glyphs file uses stuff that is known to not be compilable with fontmake?

davelab6 commented 6 years ago

Per FAlthausen/Vollkorn-Typeface#22 we should check upstream projects for a build script

I guess this is simply looking for a file named build.py or build.sh anywhere, warning if yes, or if there is more than 1, and then passing when there is one in /sources/build.{py,sh}

A second check would be that it works, I guess :)

I also wonder that we could have a check that the output of fontmake equals the output of GlyphsApp, or, if the .glyphs file uses stuff that is known to not be compilable with fontmake?

These 2 things are really a huge whole other project, about making a full 'build pipeline', and I want to postpone that into 2019 (easily :)