fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
558 stars 103 forks source link

🚨🚨🚨 Test downstream integrations do not break 🚨🚨🚨 #2038

Open davelab6 opened 6 years ago

davelab6 commented 6 years ago

Observed behaviour

It is possible for us to merge in changes to master and release them that will break tools that use fontbakery (gf-dispatcher, fontbakery-dashboard, maybe more) - and it should not be.

Expected behaviour

We need to ensure that all tools that use fontbakery (gf-dispatcher, fontbakery-dashboard, maybe more) are always capable of running the latest pypi release, or even the latest master branch, so prevent any changes from being released or merged in future that break them.

Resources and exact process needed to replicate

We need to enumerate the tools that use fontbakery, and begin writing code tests for their usage.

felipesanches commented 6 years ago

Thanks for reporting that. It does indeed seem to be important to protect against breaking those tools in the future. But was this issue reported after something actually breaking? Or is it only a matter of precaution?

m4rc1e commented 6 years ago

Dispatcher and gftools are currently py2 only.

madig commented 6 years ago

Great, that makes them break perpetually unless you invoke fontbakery through subprocess ;) I suggest 🐍 🐍 🐍

felipesanches commented 4 years ago

@m4rc1e, I suppose that at this point in time these tools were already ported to python 3, right?

graphicore commented 4 years ago

Dashboard/dispatcher is all py3 now. However, there are other ways Font Bakery can trouble the dispatcher, e.g. by breaking assumptions made about the file structure it's running in. Thinking about the "superfamily tests" for example.

m4rc1e commented 4 years ago

gftools, diffbrowsers and font diffenator are all py3 :-)