Check ligatures are consistent

fonttools / fontbakery

🧁 A font quality assurance tool for everyone

https://fontbakery.readthedocs.io

Apache License 2.0

546 stars 99 forks source link

Check ligatures are consistent #2747

Open davelab6 opened 4 years ago

davelab6 commented 4 years ago

Observed behaviour

https://twitter.com/mjdye/status/1223762539768467456?s=19

So, I’m playing around with @ebensorkin 's Gelasio on google fonts and have noticed ligatures are weirdly inconsistent. See screenshot. Is that a mistake or is that intentional? https://t.co/UaXivIpZ1z

IMG_20200201_200959

Expected behaviour

Ligatures should be technically checked for existing, and visually checked for similarities. The latter might be more of an exq thing

felipesanches commented 4 years ago

could you please clarify "exq thing"?

felipesanches commented 4 years ago

Are we discussing here a proposal of a check specific to fi-fl-ffi-ffl ligatures?

Or are we talking bout a broader issue that involves a larger set of potential ligatures?

felipesanches commented 4 years ago

also...

"checked for existing" sounds like something easily scriptable as long as we have a list of pairs to check against
"visually checked for similarities" sounds like a task for actual human type-designers to do so it might be dashboard-level.

davelab6 commented 4 years ago

Eqx, by sorkin type

On Tue, Feb 11, 2020, 8:14 PM Felipe Corrêa da Silva Sanches < notifications@github.com> wrote:

Assigned #2747 https://github.com/googlefonts/fontbakery/issues/2747 to @davelab6 https://github.com/davelab6.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/googlefonts/fontbakery/issues/2747?email_source=notifications&email_token=AAB73S6H7KX74RHOPQUYGJTRCNEQFA5CNFSM4KOWUD52YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWSE5UOQ#event-3028933178, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB73S2ZUBWO3L5B6L3BM33RCNEQFANCNFSM4KOWUD5Q .

EbenSorkin commented 4 years ago

Yeah this could be an EQX pass fail question or possibly 2+ basic questions which build to a family consistency question. I'll have a look at this post Merriweather and revise the source. For some reason I don't recall if I made Gelasio into a VF. If I somehow didn't I'll do that as well.