fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
552 stars 102 forks source link

fontbakery has difficult time parsing numbers in names #2864

Open EwonRael opened 4 years ago

EwonRael commented 4 years ago

Observed behaviour

When I run check-googlefonts on the files in my Bodoni Moda font I get a lot of errors related to the name such as

Check name table: FULL_FONT_NAME entries. or Check name table: TYPOGRAPHIC_FAMILY_NAME entries.

in all cases it's expecting my font to be named "Bodoni Moda11" instead of the proper name "Bodoni Moda 11"

I assume this is because it comes up with the expected font name based off of the postscript Font Name or something of the sort that can't have spaces and then it's adding spaces when there's a lowercase letter next to an uppercase one? In any case (haha) it's throwing up issues and I'm not convinced it should be in this case.

Expected behaviour

I don't want errors here.

Resources and exact process needed to replicate

just run check-googlefonts on the fonts in the google branch of my Bodoni

https://github.com/indestructible-type/Bodoni/tree/google

aaronbell commented 4 years ago

I am also running into an issue while working on this font. note I am proposing to rename the font to "Rock 3D Font".

However, fontbakery gives these fail reports:

🔥 FAIL Entry [FONTFAMILYNAME(1):WINDOWS(3)] on the "name" table: Expected "Rock 3 D Font" but got "Rock 3D Font". [code: mismatch]

🔥 FAIL Entry [FULLFONTNAME(4):WINDOWS(3)] on the "name" table: Expected "Rock 3 D Font Regular" but got "Rock 3D Font Regular". [code: bad-entry]

Usually 3D is displayed as a single word, rather than 3 D, so the above errors are incorrect.