Open guidoferreyra opened 1 year ago
@guidoferreyra fontbakery is only applying the google fonts requirements in this case, if any question about the axis, better to ask directly there: https://github.com/googlefonts/axisregistry.
The GF guide gives more explanation about the slant axis support: https://googlefonts.github.io/gf-guide/variable.html#ital--slnt, but it probably won't answer totally your question. Basically, it's not about what would be nice to do, it's about what the API can do. There are exception though, we have to see that case by case.
Hi @RosaWagner I think this check is on Universal profile https://github.com/googlefonts/fontbakery/blob/0dd4631a35a31f1df903438a595e62fa589e1eba/Lib/fontbakery/profiles/universal.py#L766
That is then indeed problematic. One can choose whatever value for their own font.
Should we migrate it to Google Fonts profile, then?
See also: https://github.com/googlefonts/fontbakery/issues/2863, where the check was originally discussed/proposed
I think the check has value for the Universal profile, specially because is very often to see fonts compiled with Glyphs with bad STAT tables or where the parameters were not correctly set and using AxisValue like "Light Italic" for wght axis.
On the Universal profile I think com.adobe.fonts/check/STAT_strings
should be used instead of com.google.fonts/check/STAT_strings
.
In sumary because AF check accepts "italic" Axis Value Name on slnt
axis.
Observed behaviour
When using "Italic" as axisValue on the 'slnt' axis the check fails. I understand the purpose of this check for other axes but I don’t see a reasong why "Italic" can not be allowed for Slant axis.
Many times Slant axis will not only varies the inclination angle but also introduces changes on the glyphs shape and using other names like "Oblique" does not make sense.