fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

Parameterize install_run and fix typenetwork profile #4601

Closed simoncozens closed 3 months ago

simoncozens commented 3 months ago

Description

Relates to issue #4519, in which we found that we don't have integration tests for the TypeNetwork profile. This PR makes the integration tests parameterised, which in turn makes it easier to add new profile tests (which in this case, I have done!)

Checklist

simoncozens commented 3 months ago

The typenetwork integration check fails. Which is good, because there's a problem there we need to fix!

simoncozens commented 3 months ago

There were various problems with the typenetwork profile that this exposed: missing dependencies, and also a broken check implementation. Fixed them too.

felipesanches commented 3 months ago

Awesome!

felipesanches commented 3 months ago

The CI job seems to be stuck.

Can I start performing code-review? I'll probably make small changes and that will naturally restart the CI jobs.

simoncozens commented 3 months ago

Of course, fine with me!

felipesanches commented 3 months ago

I don't understand why the install-run jobs get stuck:

Screenshot from 2024-03-18 12-11-31

simoncozens commented 3 months ago

It did finish (https://github.com/fonttools/fontbakery/actions/runs/8328519921); I'm not sure why it says it hasn't. Maybe we're now launching too many jobs, but that's just a guess.

felipesanches commented 3 months ago

@guidoferreyra independently addressed a few of these typenetwork profile issues at #4604

felipesanches commented 3 months ago

I will update and force-push this PR now to fix the conflict caused by merging #4604 first

felipesanches commented 3 months ago

The problem was that the names of jobs changed and it was still waiting to run 3 of the required jobs based on their old names.

So I changed the repo settings accordingly and merged it.