fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
548 stars 99 forks source link

Handle vendor IDs that are fewer than 4 characters #4605

Closed arrowtype closed 6 months ago

arrowtype commented 6 months ago

Description

The OS/2 Vendor ID is specced as a string of four characters. However, a font Vendor ID will often be fewer than four characters, so this field gets filled in with either spaces or null characters. For example, here’s how vendor ABC might appear:

<achVendID value="ABC\x00"/>
<achVendID value="ABC "/>

So, this PR strips those filled characters out before comparing the vendor ID against the configured expectation.

Checklist

arrowtype commented 6 months ago

Apparently, this was actually an issue in FontMake that was fixed already. So, this PR is irrelevant.