search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
548 stars 99 forks source link

com.google.fonts/check/ttx_roundtrip: use subprocesses to invoke TTX #4630

Closed RickyDaMa closed 5 months ago

RickyDaMa commented 5 months ago

Description

Should fix #4481

Refactors com.google.fonts/check/ttx_roundtrip to use subprocess.Popen on ttx instead of calling ttLib directly. This means that we can use subprocess' built-in handling of stdout and stderr, instead of the previous TTXLogger that was disrupting progress reporting while this check was being run (see my post on #4481 for the full explanation on how these are linked)

I've tested locally and am no longer able to reproduce the original issue

Checklist

RickyDaMa commented 5 months ago

@felipesanches if you wouldn't mind reviewing when you have time please & thank you 🙏

MariannaPaszkowska commented 5 months ago

cc @simoncozens

felipesanches commented 5 months ago

I'll review this today

simoncozens commented 5 months ago

Much nicer way to do it, but Felipe has merge access and I don't... ;-)

felipesanches commented 5 months ago

thanks, @RickyDaMa

I'll make a few tweaks and merge it at PR #4631