Problem with fontbakery.com

[schriftgestalt]

When I open fontbakery.com, after a few seconds I get this:

Traceback (most recent call last):
  File "/lib/python311.zip/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "", line 1209, in _gcd_import
  File "", line 1181, in _find_and_load
  File "", line 1152, in _find_and_load_unlocked
  File "", line 690, in _load_unlocked
  File "", line 940, in exec_module
  File "", line 241, in _call_with_frames_removed
  File "/home/pyodide/fbwebapi.py", line 33, in 
    import glyphsets
  File "/lib/python3.11/site-packages/glyphsets/__init__.py", line 34, in 
    assert type(GLYPHDATA) is glyphsLib.glyphdata.GlyphData
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

[guidoferreyra]

Same here.

[yanone]

@felipesanches This code got introduced way back when I startet revamping glyphsets, so pinning it to 0.6.17 doesn't even help. (And also the error persists on fontbakery.com)

In any case, this code was a workaround for GLYPHDATA in glyphsLib not properly loading unless a get_glyph() command was issued first. I removed the lines now and glyphsets own CI passes. Do you have a way to test the repo code in fontbakery.com before me releasing a new package? Can you link to the repo directly?

[felipesanches]

I'm afraid we don't have an easy way of testing fontbakery.com with a dependency installed from a git repo. Maybe @simoncozens knows some way of doing it?

[simoncozens]

Yep, we can check out the gh-pages branch locally and change the pip commands. I'll have a go later.

[felipesanches]

great, thanks!

[simoncozens]

I can confirm the git version works fine. (It wasn't as simple as pointing micropip at the repo, because it doesn't support loading packages from git - I had to build a wheel and copy that into the gh-pages directory and then have it load that. But hey, it works.)

@yanone I would consider removing all those commented out lines; GLYPHDATA doesn't seem to be used in glyphsets at all.

[felipesanches]

thanks, @simoncozens

@yanone, I'll update pyproject.toml to unpin glyphsets once we get a new version of it released

[guidoferreyra]

TN profile is failing now and it shows the following:

I’m not getting that error either on the latest commit nor latest stable release (0.12.1)

[felipesanches]

TN profile is failing now and it shows the following:

I’m not getting that error either on the latest commit nor latest stable release (0.12.1)

Are you running the web-version via a checkout of gh-pages locally on your computer?

Or is it a screenshot of the publicly deployed fontbakery.com?

[felipesanches]

What is puzzling to me right now is that this screenshot has an ImportError for DecomposingFilterPointPen from fontTools.pens.filterPen.

• I see that fontTools added that import statement on a commit that is included in fonttools==4.50.0 (https://github.com/fonttools/fonttools/commit/d84c74c2ab15d99af74ea1555acdd8fcd4699189)
• the crashing code that fails to import that was added in a commit included on ufo2ft==3.2.0b1(https://github.com/googlefonts/ufo2ft/commit/a49d83e4d65695cb084e8619d1cc50c43bcf30c3)
• That version of ufo2ft already had fonttools>=4.50.0 listed in its setup.py (https://github.com/googlefonts/ufo2ft/blob/v3.2.0b1/setup.py#L32)

So, I cannot see how would it be possible for this to go wrong, considering the resolution of all these dependency requirements.

[felipesanches]

I've just released FontBakery v0.12.2 and fontbakery.com seems to be working nicely. But I will leave this issue open for a while, to discuss @guidoferreyra's problem which sounds to me like a broken dependency resolution on his local environment.

[guidoferreyra]

Are you running the web-version via a checkout of gh-pages locally on your computer?

Or is it a screenshot of the publicly deployed fontbakery.com?

Sorry I didn‘t add much context, that’s screenshot is from Fontbakery.com.

Web version is working for other profiles, but if you select TN‘s, drop a font and wait a bit you will see the error message.

[felipesanches]

I am unable to replicate the problem here. Can you still get that error now that v0.12.2 was released?

[guidoferreyra]

Now I see it only happens with one specific font. Unfortunately I can‘t share that font. Anyway I gues this is fixed, I will keep an eye in case the error is raised for another font.

Thanks!!

[felipesanches]

thanks!