search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
548 stars 99 forks source link

[com.google.fonts/check/glyphsets/shape_languages] output is overly repetitive #4646

Closed bobh0303 closed 5 months ago

bobh0303 commented 5 months ago

(NOTE: Please include the check-id in the issue's title.)

Observed behaviour

The same error is output multiple times, even for the same language.

For example, when testing SIL's Doulos font, v6.200, excerpt of the output for Mundani language is:

           mnf_Latn (Mundani)                           Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0268.sc
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0268.Dotless.sc
           ^                                            Shaper didn't attach uni0327 to uni0268.Dotless.sc
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0268.Dotless.sc
           ^                                            Shaper didn't attach uni0327 to uni0268.Dotless.sc
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0268.Dotless.sc
           ^                                            Shaper didn't attach uni0327 to uni0268.Dotless.sc
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0254.sc
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0254.sc
           ^                                            Shaper didn't attach uni0327 to uni0254.sc
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0254.sc
           ^                                            Shaper didn't attach uni0327 to uni0254.sc
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0254.sc
           ^                                            Shaper didn't attach uni0327 to uni0254.sc
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0186
           ^                                            The locl feature did not affect Eng

Expected behaviour

Errors should be output only once, or at most once per language. Removing redundant lines from the above and sorting yields only 6 unique messages related to Mundani:

           mnf_Latn (Mundani)                           Shaper didn't attach uni0327 to uni0186
           ^                                            Shaper didn't attach uni0327 to uni0197
           ^                                            Shaper didn't attach uni0327 to uni0254.sc
           ^                                            Shaper didn't attach uni0327 to uni0268.Dotless.sc
           ^                                            Shaper didn't attach uni0327 to uni0268.sc
           ^                                            The locl feature did not affect Eng

Resources and steps needed to reproduce

Doulos SIL, v6.200, downloadable from https://software.sil.org/doulos/download/

Command:

fontbakery check-googlefonts -c com.google.fonts/check/glyphsets/shape_languages DoulosSIL-Regular.ttf | more

(Mundani is the 2nd language mentioned in the output)

fontbakery from source at tag v0.12.1 python 3.10.12 ubuntu 22.04

bobh0303 commented 5 months ago

Excellent! Thanks.

felipesanches commented 5 months ago

you're welcome ;-)