search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

Documentation for running tests fails to mention extra dependencies #4648

Closed drj11 closed 2 months ago

drj11 commented 2 months ago

Observed behaviour

python -m pytest

Followed by 28 errors. Mostly of the form: import defcon E ModuleNotFoundError: No module named 'defcon' but at least one of the form from glyphsLib import GSFont E ModuleNotFoundError: No module named 'glyphsLib'

I deduce that i am missing some dependencies. Which is fine, and i will endeavour to find out what they are. But installing those dependencies for testing should be on the Source Code Testing page https://font-bakery.readthedocs.io/en/stable/developer/source-contrib-guide.html#source-code-testing

Expected behaviour

Tests should run, mostly without errors?

Resources and steps needed to reproduce

My main is at f8d2f3ee7ddf0923b150cf8452381a6dc0f84188

I'm running in a fresh venv i made today, following the installation instructions https://font-bakery.readthedocs.io/en/stable/developer/source-contrib-guide.html#

drj11 commented 2 months ago

python -m pip install defcon glyphsLib helps, but still get many failures, many seem to be related to missing modules.

felipesanches commented 2 months ago

You need to do pip install .[all] before running the tests. I will review the docs to make sure this is mentioned.

felipesanches commented 2 months ago

Ooops! Actually what you really need is pip install .[tests]