search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
548 stars 99 forks source link

[web] improvements to HTML page #4658

Closed simoncozens closed 5 months ago

simoncozens commented 5 months ago

@yanone said elsewhere:

Having never seen this report before, it's a bit difficult to use in terms of understanding what types of results are what. The colors on the left don't bear any meaning on their own, and neither do the icons at the top. There is no relation between icons and colors.

I would like to ask to make it explicit which check is a FAIL, WARN, etc. by adding a header between each category on the left that says icon+FAIL. Additionally, please ad FAIL, WARN etc. to the icons at the top.

Also, please add a Fontbakery version somewhere in the document so it becomes clear what I'm looking at. (I got sent this in an issue and have no idea where this came from, hence my initial question.)

The black menu items don't change color when clicking on them. And only the purple has a functioning mouse-over effect.

simoncozens commented 5 months ago

Fixed in 9f8fc972.

guidoferreyra commented 5 months ago

Hi @simoncozens I noticed that some failing checks are not being grouped correctly. In the image below you can see a failing check along the passing checks.

imagen

Same with warns imagen

And FAILS with SKIPs imagen

simoncozens commented 5 months ago

Would love to be able to reproduce that but instead FB exploded with an interesting error message:

  File "/lib/python3.11/site-packages/ufo2ft/util.py", line 17, in 
    from fontTools.pens.filterPen import DecomposingFilterPointPen
ImportError: cannot import name 'DecomposingFilterPointPen' from 'fontTools.pens.filterPen' (/lib/python3.11/site-packages/fontTools/pens/filterPen.py)

DecomposingFilterPointPen was added to fontTools in version 4.50.0. I wonder why we're not picking up that version.

guidoferreyra commented 5 months ago

Oh! I’m not getting that one, weird.

felipesanches commented 5 months ago

DecomposingFilterPointPen was added to fontTools in version 4.50.0. I wonder why we're not picking up that version.

I was having the same thought last week at https://github.com/fonttools/fontbakery/issues/4639#issuecomment-2061988927