fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
548 stars 99 forks source link

[com.fontwerk/check/style_linking] false fails on styles such as "Extra Bold" and "Semi Bold" #4667

Closed arrowtype closed 5 months ago

arrowtype commented 5 months ago

Observed behaviour

Many font designers and foundries are adamant that spaces belong in font style names such as Familyname Extra Light and Familyname Semi Bold. I personally prefer the approach of Pascal Casing, like Familyname SemiBold, but I also feel that Fontbakery should be separate this opinion from a check of whether a font style is bold.

Specifically, com.fontwerk/check/style_linking relies on the is_bold condition to say whether a font has proper style linking metadata, but it presents fails for fonts if they use spaces in weight names.

Expected behaviour

I would expect the is_bold condition to be a little more flexible towards different naming philosophies.

Resources and steps needed to reproduce

This is true as of the latest Fontbakery version, at d7175d583b1e1ba618255aa3e23165686b08fa2b, for any font that includes spaces in bold-adjacent style names.