Make is_bold condition work with more style naming formats

[arrowtype]

Description

Relates to issue https://github.com/fonttools/fontbakery/issues/4667

Changes:

• Add a util to check if a bold-adjacent style name (such as Semi Bold or SemiBold) is in a font’s full name, bold_adjacent_styles_in_full_font_name()
• Adjust the is_bold condition to check for bold-adjacent style names, and not consider such styles as "Bold" in the RIBBI sense

If this is an acceptable change, I can update the changelog, etc. I’m partly submitting this so I can present a proposed solution, rather than just a complaint.

Checklist

• [x] update CHANGELOG.md
• [ ] wait for the tests to pass
• [ ] request a review

[felipesanches]

yes, this is an acceptable change ;-)

Thanks!

[felipesanches]

Be sure to run black on your code:

[arrowtype]

Hey @felipesanches, thanks so much for the review! Ha, don’t know how I managed to double up on the .lower(), but I’ve corrected that and formatted with Black. I’ve also attempted to update the changelog, but I’m not 100% sure of the best message to include there. Please feel free to adjust that as you see fit!

[felipesanches]

Great! I'll take a look, thanks

[felipesanches]

Even though the condition is globally available, the is_bold condition is currently only used in the implementation of com.fontwerk/check/style_linking, which is included in both FontWerk and Type Network profiles.

Are you using one of these profiles? Or do you plan to use is_bold on some other check?

[felipesanches]

I see that at https://github.com/fonttools/fontbakery/issues/4667#issue-2259756279 you mentioned com.fontwerk/check/style_linking explicitly, so I will move on with the code-review to merge this.

[arrowtype]

Awesome, thanks for your review and all your help here, @felipesanches!