search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

[com.google.fonts/check/caret_slope] Downgrade to WARN #4679

Closed simoncozens closed 2 months ago

simoncozens commented 2 months ago

Observed behaviour

We currently FAIL if the caret slope rise and run values are wrong for italic glyphs. But according to @vv-monsalve, no applications these days display a slanted cursor caret!

Expected behaviour

We shouldn't FAIL for non-problems.

felipesanches commented 2 months ago

If it is not a real problem, should we then deprecate the check?

Or would you prefer to keep it as a WARN? Any hope this will someday be supported at all?

kenmcd commented 2 months ago

It appears that some applications still support it. Slanted Cursor in Word 2024

and Slanted Cursor Aptos Serif on Affinity Publisher

vv-monsalve commented 2 months ago

After the latest tests I performed, it's not in use on

Only Word (mac + Win) seemed to be working ok with them.

Edit: platform info clarified

@kenmcd what OS and app versions are these?

vv-monsalve commented 2 months ago

Or would you prefer to keep it as a WARN? Any hope this will someday be supported at all?

I would keep it as a WARN. Caret values are part of the hhea table from the OT spec, so they should be supported. However, multiple apps are not using them to represent a slanted cursor.

kenmcd commented 2 months ago

@kenmcd what OS and app versions are these?

Word Office 2024 Preview on Windows 11 Pro 23H2 Microsoft® Word LTSC MSO (Version 2403 Build 16.0.17425.20176) 64-bit

Word Office 2019 on Windows 10 Pro 22H2 Microsoft® Word 2019 MSO (Version 2402 Build 16.0.17311.20000) 64-bit I installed 2021 over 2019 and this is what it still says.

Affinity Publisher 2.4.1 on Windows 10 Pro 22H2