fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

Some results sometimes not shown in HTML output #4687

Open eweracs opened 2 months ago

eweracs commented 2 months ago

Observed behaviour

I've found that, contrary to the log in the terminal (and the result on fontbakery.com), the HTML output does not list some of the results. The result icons are listed in their respective sections, but the sections are otherwise empty:

image

Expected behaviour

The results (most importantly, the FAILs) should be listed in their sections.

Resources and steps needed to reproduce

I can't provide the file I am working on, but I have noticed this multiple times with numerous files. It works fine on fontbakery.com.

guidoferreyra commented 2 months ago

It happens the same to me.

eweracs commented 2 months ago

I see where the issue might stem from:

The results are thrown into the "pass" section, also on fontbakery.com:

image

This only happens if at least one font file passes. If all font files fail the check, the result is correctly listed under "failing checks".

guidoferreyra commented 1 month ago

@felipesanches just adding you in case it flew under the radar. I think this is critical, failed checks are been kind of disguissed as PASS since there is no easy way to spot it on the report.

guidoferreyra commented 1 month ago

Just bumping this one since this IMO is kind of critical

felipesanches commented 1 month ago

@guidoferreyra, thanks for the reminder!

felipesanches commented 4 weeks ago

I've been trying to replicate this, but I have not seen it happen in any of my attempts. Please try to build a sample font that causes this problem so that I have something to reproduce the bad output and debug the implementation.

I'm moving this to the next milestone, as I'm about to cut a new release now.

guidoferreyra commented 3 weeks ago

Hi @felipesanches, sorry for the delay here are some sample files, fonts and html report. See the sections with fails but not checks details, eg. "head table"

SampleFiles.zip

felipesanches commented 1 week ago

ok, I'll inspect these now. Thanks.