Improve tabular_kerning check

fonttools / fontbakery

🧁 A font quality assurance tool for everyone

https://fontbakery.readthedocs.io

Apache License 2.0

534 stars 99 forks source link

Improve tabular_kerning check #4691

Closed yanone closed 2 months ago

yanone commented 2 months ago

Description

Relates to issue #4640

Eliminated false positives and other errors. Particularly FAILs are down from 147 to 103.

Before (entire GF library): Bildschirmfoto 2024-05-02 um 15 41 37

After: Bildschirmfoto 2024-05-02 um 14 52 19

Checklist

[X] update CHANGELOG.md
[x] wait for the tests to pass
[x] request a review

Fixes #4640

yanone commented 2 months ago

@felipesanches When you merge this, reset the timer for the experimental flag. There are no known issues left here.

felipesanches commented 2 months ago

For how many more weeks would you suggest we keep this check marked as experimental?

yanone commented 2 months ago

That's a question of taste for you, the maintainer. I think the results speak for themselves now in terms of reduction in FAILs and ERRORs, so you could very well say it's mature now. Or you still want to be cautious and leave the experimental flag for another while.

From my side there's nothing left to improve right now.

felipesanches commented 2 months ago

Great! Thanks!