search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

[com.google.fonts/check/tabular_kerning] Adding PUA code points to 'cmap' creates false positives #4697

Closed dscorbett closed 1 month ago

dscorbett commented 2 months ago

Observed behavior

com.google.fonts/check/cmap/alien_codepoints fails with the code pua-encoded if com.google.fonts/check/tabular_kerning runs first because, as of #4691, the latter mutates the font by adding PUA code points to it.

Expected behavior

The result of a check should not depend on whether a different check ran first.

Steps needed to reproduce

curl -LO https://github.com/notofonts/latin-greek-cyrillic/releases/download/NotoSans-v2.013/NotoSans-v2.013.zip
unzip NotoSans-v2.013.zip
pip install 'fontbakery[notofonts]==0.12.5'
fontbakery check-notofonts -c com.google.fonts/check/tabular_kerning -c com.google.fonts/check/cmap/alien_codepoints NotoSans/unhinted/otf/NotoSans-Regular.otf