Don't change working directory during `git_rootdir`

fonttools / fontbakery

🧁 A font quality assurance tool for everyone

https://fontbakery.readthedocs.io

Apache License 2.0

534 stars 99 forks source link

Don't change working directory during `git_rootdir` #4704

Closed RickyDaMa closed 1 month ago

RickyDaMa commented 1 month ago

Description

Fixes #4700

Applies the recommended fix to have the git subprocess handle directory changing, instead of changing directory for the whole process (including other jobs currently in progress when --auto-jobs is used)

Checklist

[x] update CHANGELOG.md
[x] wait for the tests to pass
[x] request a review

RickyDaMa commented 1 month ago

@simoncozens since Felipe is on a well-needed break, would you mind taking a look at this please?

simoncozens commented 1 month ago

I can take a look, but that's all I can do. :-) It looks good to me.

felipesanches commented 1 month ago

This will resume at PR #4708