fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

WIP: Sort outlines by area (descending) so that largest outline is used fo… #4723

Closed yanone closed 1 month ago

yanone commented 1 month ago

…r contour direction measurement

Description

Relates to issue #X

(Provide a list of all the noteworthy changes you've done. Elaborate on any decisions you had to make, and include links and/or screenshots, if applicable)

Checklist

dscorbett commented 1 month ago

The new algorithm only checks the contour with the largest area, which won’t catch a glyph with multiple outer contours whose smallest outer contour is counterclockwise. For example, consider a glyph for ⟨å⟩ where the base letter’s outer contour is fine but the ring’s is wrong.

yanone commented 1 month ago

@dscorbett Yes, we were debating that here.

This PR is likely going to end up getting deleted, as @simoncozens wants to revisit his previous version which was reporting false positives for some glyphs but otherwise tried to consider glyphs with several outer contours.

Thank you.

simoncozens commented 1 month ago

I think #4724 is a replacement.