fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

Interpolation errors check #4726

Open tphinney opened 1 month ago

tphinney commented 1 month ago

Observed behaviour

The check fails to complete with a ZeroDivisionError. The problem is very similar to that described in #4699, but the details of the error message are not identical to that one. Plus I am running the very latest Fontbakery as of a few hours ago.

NOTE that this is a pretty weird font. In many masters, some contours genuinely ARE collapsed down to a single point. This is “normal” for this font, and has to do with how the animated fill axis works. So, a rejection by Fontbakery is ok, but a div-by-zero error is not ideal.

(If you tell me I just need a custom override to not run certain checks, I will not be shocked.)

Screenshot 2024-05-16 at 1 08 39 PM

Expected behaviour

The check should complete and give better feedback.

Resources and steps needed to reproduce

This can be reproduced with the font file currently available at https://github.com/google/material-design-icons/blob/master/variablefont/MaterialSymbolsOutlined%5BFILL%2CGRAD%2Copsz%2Cwght%5D.ttf

Using:

The problem is new since I upgraded Fontbakery, but I think the check itself was added since my previous Fontbakery version.