Revised `tabular_kerning` check another time

fonttools / fontbakery

🧁 A font quality assurance tool for everyone

https://fontbakery.readthedocs.io

Apache License 2.0

534 stars 99 forks source link

Revised `tabular_kerning` check another time #4738

Closed yanone closed 1 month ago

yanone commented 1 month ago

Description

Revised tabular_kerning check another time to remove even further false positives (issue #4640)

Rewrote the check to not map unencoded glyphs to PUA in fonttools, but rather override the glyph mapping function in uharfbuzz.

The FAILs on the GF library have dropped from 99 to 49. Execution speed on the entire GF roughly doubled.

Checklist

[X] update CHANGELOG.md
[x] wait for the tests to pass
[x] request a review

felipesanches commented 1 month ago

@yanone yesterday you marked this as "ready for review" but this morning there's been many new commits added. Should I wait a bit longer or is it really ready for review now?

yanone commented 1 month ago

@felipesanches It's ready. I looked over the code and optimized it a bit more yesterday, but I'm done now. Thank you.