fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
553 stars 102 forks source link

New check: Metadata invalid minisite_url #4739

Open vv-monsalve opened 5 months ago

vv-monsalve commented 5 months ago

What needs to be checked?

If minisite_url has a random text instead an http:// + domain string the push to dev gets broken.

Resources and steps needed to reproduce the problem

(Provide the steps and files for reproducing the problem. We will need them for developing the proposed check and for including them in tests that validate the codebase)

Suggested profile

Suggest which profile the check should be added to. The most common are:

Suggested result

Which log result level should the check have:

Severity assessment

5, causes servers to fail.

vv-monsalve commented 5 months ago

This happened here https://github.com/google/fonts/pull/7762/files

felipesanches commented 5 months ago

we already have com.google.fonts/check/metadata/minisite_url, but it only alerted us when decluttering was needed (such as removing extra white-space). I'll add a URL check to see if the url is not broken, Similar to other URL checks, if it doesn't return a 404 HTTP error code, then it means it is a good URL.