Add latest font_public proto

fonttools / fontbakery

🧁 A font quality assurance tool for everyone

https://fontbakery.readthedocs.io

Apache License 2.0

534 stars 99 forks source link

Add latest font_public proto #4756

Closed simoncozens closed 3 weeks ago

simoncozens commented 4 weeks ago

Description

Relates to an issue in another repo (https://github.com/google/fonts/pull/7792). We have a primary_language field in the textproto now, so METADATA.pb files with that field should not cause a parsing error.

Checklist

[ ] update CHANGELOG.md
[x] wait for the tests to pass
[x] request a review

simoncozens commented 4 weeks ago

I don't get it. I copied the protobuf files from gftools, which in theory has the same bounds on the protobuf version dependencies, but the generated code in this PR is very different to the existing code in fontbakery, so clearly the protoc version is different. pytype is giving an error even though from fontbakery.fonts_public_pb2 import FamilyProto succeeds. I don't know why pytype was happy before but unhappy now.