search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

[com.fontwerk/check/style_linking] Should Pass fonts with Platform mac name ID 2 name not italic? #4762

Open guidoferreyra opened 3 weeks ago

guidoferreyra commented 3 weeks ago

Observed behaviour

On a font that has properly set fsSelection and macStyle to Italic but the name record 2 for mac platform is not Italic the check raises a FAIL:

MyFont-BookOblique.otf FAIL : name ID should be (most likely) 'Italic'.

AFAIK the limitation of ID 2 to be only Regular, Bold, Italic, Bold Italic is only for win platform.

Should the check be more specific here? https://github.com/fonttools/fontbakery/blob/036c8fb74d51186401a9f277994e9fb35fb38f3d/Lib/fontbakery/checks/fontwerk.py#L257

cc @ollimeier

ollimeier commented 1 week ago

Thanks @guidoferreyra for the hint, but this is intended. Even though you're right, the real world shows different rules. When eg. Mac and Win name ID is different, it causes other issues like cross platform issues. To be on the save side, we stick to Regular, Bold, Italic, Bold Italic also for Mac entries. This is based on experiences I made over years in Quality Assurance.

cc @fontwerk

guidoferreyra commented 4 days ago

Thanks for the answer.