search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

[com.google.fonts/check/description/broken_links] A 403 is not a broken link #4764

Open simoncozens opened 2 weeks ago

simoncozens commented 2 weeks ago

Observed behaviour

The following links are broken in the farticle file:
https://scriptsource.org/scr/Ital (status code: 403)

Expected behaviour

A 403 is fine because it is often used to redirect a "friendly" URL (like the one above) to another URL in the CMS (in this case https://scriptsource.org/cms/scripts/page.php?item_id=script_detail&key=Ital).

Also it shouldn't say farticle.

felipesanches commented 1 week ago

403 is HTTP Error: Forbidden. Are you sure this is used for redirects? I have never heard of that and it does not sound right to me.

Is this specific site generating an invalid HTTP code?

Or, if this is actually a common practice, then how would we distinguish it from actual "error forbidden" pages?

simoncozens commented 1 week ago

I misdiagnosed this.

In the browser, https://scriptsource.org/scr/Ital gives a redirect, but from a requests request, it gives a 403. We need to be better at faking being a browser...