fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
534 stars 99 forks source link

fix code-testing involving @cff_analysis condition #4771

Open felipesanches opened 1 week ago

felipesanches commented 1 week ago

While porting the new check com.adobe.fonts/check/cff_ascii_strings from OpenBakery (issue #4619), I left a test-case commented out because the cff_analysis condition is ignoring changes made to the ttFont object on a code-test.

The reason for that is that a new fonttools.ttLib.TTFont object is created based on the original file, which effectively discards any changes made by the code-test prior to invoking the check.

https://github.com/fonttools/fontbakery/commit/a326e75cc67c2a66de474dedb04bc63eeaa0ed6c