search

fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
548 stars 99 forks source link

[com.google.fonts/check/glyphsets/shape_languages]: Output is too long #4781

Closed m4rc1e closed 1 week ago

m4rc1e commented 3 months ago

scroller

This check has made the report for Montserrat 20x+ longer.

m4rc1e commented 2 weeks ago

@felipesanches Possible to look into this since it makes reports a complete mess. You can use Merriweather as a reference, https://github.com/ebensorkin/Merriweather4

felipesanches commented 2 weeks ago

@m4rc1e, I'm having some trouble when trying to build the fonts from that Merriweather4 repo:

Screenshot from 2024-09-18 02-38-44

Can you help me troubleshoot that? Or, alternatively, can you provide me some sample prebuilt font binaries?

m4rc1e commented 2 weeks ago

There's a release zip, https://github.com/EbenSorkin/Merriweather4/releases/tag/4.007

felipesanches commented 2 weeks ago

thanks!

felipesanches commented 2 weeks ago

The culprit here seems to be the message "The locl feature did not affect Eng", where 'Eng' is "(capital: Ŋ, lowercase: ŋ) a letter of the Latin alphabet, used to represent a voiced velar nasal (as in English singing) in the written form of some languages and in the International Phonetic Alphabet."

I wouldn't like to add such a specific hardcoded filtering to omit this message. We should verify whether the shaperglot message complaining about the Eng glyph is bogus or actually valid.

If filtering is needed, then I'd suggest adding to the output some message such as: "The shaperglot failures listed below happened too often: \<and a bullet list of them all de-duplicated to keep the list short>"

m4rc1e commented 2 weeks ago

If filtering is needed, then I'd suggest adding to the output some message such as: "The shaperglot failures listed below happened too often: "

Sounds good to me. What we currently have is a fail for each language, why can't we just group all the langs together where this eng glyph is an issue. It would make the report much more concise.