fonttools / pyclipper

Cython wrapper for the C++ translation of the Angus Johnson's Clipper library (ver. 6.4.2)
MIT License
233 stars 42 forks source link

deployment to github releases from appveyor fails #18

Open anthrotype opened 6 years ago

anthrotype commented 6 years ago

The upload of the generated wheels to Github Releases requires that the admin of this repo, @greginvm, updates the auth_token field in the .appveyor.yml file with his Github API key, as explained in the inline comments in that file.

I am only a collaborator so I can push tags, but can't generate a new API token, nor I can encrypt it using the Appveyor account that is linked to this repo (that also needs @greginvm privileges).

I am thinking that maybe it's not worth keeping this "upload to github" feature. We simply need the wheels to be uploaded to PyPI, where pip can download them from. Having them on Github is a bonus but not really required.

So if we agree, I can set up Appveyor and Travis to upload the wheels directly to PyPI using my own PyPI credentials (i have access to the pyclipper PyPI account so it should work).

anthrotype commented 6 years ago

for now I manually downloaded the wheels from appveyor, and uploaded them manually to both Github and PyPI

greginvm commented 6 years ago

Hey, @anthrotype we talked once that I'll transfer the repo to you. I just tried but I get an error because you have a fork of it. Still want to accept?

image
anthrotype commented 6 years ago

@greginvm yes, that's my fork.. Actually, I'd rather you transfer it to the fonttools organization: https://github.com/fonttools

anthrotype commented 6 years ago

and thank you! :heart:

greginvm commented 6 years ago

Hi, I can't transfer to fonttools because I don't have the "create repository" permission. We have 2 options, either I transfer it to you and then you transfer it to fonttools, or you give me create repo permissions in fonttools. Whichever options suits you better :)

https://help.github.com/articles/transferring-a-repository-owned-by-your-personal-account/#transferring-to-an-organization

image
anthrotype commented 6 years ago

you are now a member ;)

greginvm commented 6 years ago

Nice! :) Repo transfered, tell me if you need anything

anthrotype commented 6 years ago

thanks! :1st_place_medal:

greginvm commented 6 years ago

Can you do the auto upload to pypi now?

anthrotype commented 6 years ago

yes, I'm admin now. I'll do when the time comes to make a new release. The latest is already on PyPI.

greginvm commented 6 years ago

OK, great, i hope it will serve you well 😸 ! If you want you can now remove me from the fonttools org.

anthrotype commented 6 years ago

you can stay if you wish :)

greginvm commented 6 years ago

Well, I don't work on pyclipper anymore, so I don't need the membership. Thanks anyway!