search

fonttools / skia-pathops

Python bindings for the Skia library's Path Ops
https://skia.org/docs/dev/present/pathops/
BSD 3-Clause "New" or "Revised" License
47 stars 14 forks source link

make pypy wheels for Linux #46

Closed madig closed 3 years ago

anthrotype commented 3 years ago

i think you need to investigate pypy3 support in multibuild try starting from https://github.com/matthew-brett/multibuild/search?q=pypy3

madig commented 3 years ago

https://github.com/matthew-brett/multibuild/issues/373

so i need a way to set a different env depending on the selected python interpreter. groan.

Edit: https://dev.to/kanishkt123/runtime-environment-variables-with-github-actions-2if8

madig commented 3 years ago

For some reason, multibuild uses pypy2 for building the wheel or something: https://github.com/fonttools/skia-pathops/pull/46/checks?check_run_id=3221611182#step:8:201

mattip commented 3 years ago

I think this is wrong for PyPY when MB_PYTHON_VERSION already starts with py https://github.com/fonttools/skia-pathops/blob/746870053357a6457ceedfe8a3a159152272619c/config.sh#L24

madig commented 3 years ago

D'oh! Thanks for checking, I completely forgot about that substitution.

mattip commented 3 years ago

Thanks for making the effort to create wheels for PyPy. Sorry it is not a smooth experience.

madig commented 3 years ago

Thank you for your time! Pypy is still niche, so I'm certainly not expecting a smooth ride.