Closed imgios closed 4 months ago
Hi @imgios, @fonzdm ,
I will take this and will try to fix it! 😄
Hi @imgios, @fonzdm ,
I will take this and will try to fix it! 😄
Welcome aboard!
Feel free to create your first contribution, just make sure you read the guidelines 😊
Hi @imgios, @fonzdm ,
I will take this and will try to fix it! 😄
Hi @mrgionsi, please go ahead! 💪🏻
Issue fixed in #18. Thanks again, @mrgionsi!
Description
Seems like that the storage class named passed in the values
global.storageClassName
is not being used correctly when creating the PVC, so Kubernetes uses the default storage class.I think that's because there's a typo when referring to the parameter:
https://github.com/fonzdm/servarr/blob/d08a0a606a7cdd5f0d3c51ecfa9901c597643fa4/servarr/templates/pvc.yaml#L12
https://github.com/fonzdm/servarr/blob/d08a0a606a7cdd5f0d3c51ecfa9901c597643fa4/servarr/templates/pvc.yaml#L33
https://github.com/fonzdm/servarr/blob/d08a0a606a7cdd5f0d3c51ecfa9901c597643fa4/servarr/templates/pvc.yaml#L54
Steps to reproduce
helm template servarr servarr/ -f .github/ci/ci-values.yaml | egrep -i "servarr/templates/pvc.yaml|storageClassName"
or deploy it using your values.Expected behavior
The Helm Chart should generate PVC templates using the correct
StorageClassName
from the values.Servarr Helm Chart version
dev
Relevant log output
Chart values
Code of Conduct