Closed imgios closed 6 months ago
Hi @imgios , thanks for the hard work! I left some comments, please check'em out. Basically, two main thing to address
servarr
part variable with .Release.Namespace. This behavior is spread across yaml files and the python scripts, I pointed out something but not all of them. Please check if we can make them variable, otherwise we are forced to use the servarr
name as namespaceConverted the PR to draft, hopefully we will avoid countless pipelines invocation
Please check if the PR fulfills these requirements
[x] The branch naming convention follows our guidelines
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR brings few new things:
latest
to8.7.1
ImagePullPolicy
for the jobs and set it toIfNotPresent
, we can think about making it a parameter from the values but we can decide laterI hope I didn't forget anything.
We don't have any ImagePullPolicy defined and the services init are mixed in the same jobs. Moreover, almost all the images are using the
latest
tag instead of a given one.One job per service executed in a given order, with the ImagePullPolicy set to IfNotPresent in order to pull the image only if it's missing from the node.
Not really I guess
None