search

foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles 🔔 Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
471 stars 24 forks source link

Allow for baseUrl to be defined when testing multiple urls #102

Closed pmpinto closed 1 year ago

pmpinto commented 2 years ago

Is your feature request related to a problem? Please describe. Don't think so.

Describe the solution you'd like It would be great, and cleaner too, if we could have a baseUrl property where I could define Netlify's preview URL, for instance https://deploy-preview{{ PR_NUMBER }}--myapp.netlify.app/.

So that I could have:

baseUrl: 'https://deploy-preview{{ PR_NUMBER }}--myapp.netlify.app/'
urls: '/one /another /something /else'

Instead of:

urls: 'https://deploy-preview{{ PR_NUMBER }}--myapp.netlify.app/one https://deploy-preview{{ PR_NUMBER }}--myapp.netlify.app/another https://deploy-preview{{ PR_NUMBER }}--myapp.netlify.app/something https://deploy-preview{{ PR_NUMBER }}--myapp.netlify.app/else'

Describe alternatives you've considered The one from above.

adamhenson commented 1 year ago

Realistically, unfortunately, I won't be supporting this feature request.

pmpinto commented 1 year ago

Sad, but understandable. Thanks 👍

adamhenson commented 1 year ago

Sorry, I personally don’t have time. But, certainly feel free to open a PR.