foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles 🔔 Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
480 stars 24 forks source link

This github action doesn't read the configFile #118

Closed stixaw closed 5 months ago

stixaw commented 1 year ago

Describe the bug Here is my Code in the config file:

  extends: 'lighthouse:default',
  settings: {
    skipAudits: [
      'is-on-https',
      'redirects-http',
      'uses-http2',
    ],
  },
}

here is how I am calling it in the github workflow:

        uses: foo-software/lighthouse-check-action@v10.0.0
        id: lighthouseCheck
        with:
          configFile: ./lh-config-feature.js
          outputDirectory: ${{ env.LIGHTHOUSE_REPORTS_DIRECTORY }}
          urls: "http://chg-pde-comphealth-feature-${{ env.FEATURE_ID }}.s3-website-us-west-2.amazonaws.com"

Expected behavior I should see a report which doesn't show the HTTPS results but it occurs every time in our feature branches. They are on aws and can't do https.

I looked at the documentation for the lighthouse and for this action and from what I can tell it supports the use of the config file.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

adamhenson commented 5 months ago

We need to update our documentation, but newer versions of this GitHub Action, this option is called overridesJsonFile and an example is here.