search

foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles 🔔 Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
480 stars 24 forks source link

Update lighthouse package to the latest version #126

Closed RhodesPeter closed 5 months ago

RhodesPeter commented 7 months ago

Is your feature request related to a problem? Please describe. We are getting different lighthouse scores when running locally on Chrome and via the GitHub action because of a missmatch in lighthouse versions.

Describe the solution you'd like It would be awesome if the lighthouse version was updated. Current version is 12.0.0 👉 https://www.npmjs.com/package/lighthouse

Additional context We find this package very useful, thanks for building it!

frederikkempe commented 5 months ago

Yeah, would love to see the Lighthouse version updated. Thanks in advance!

adamhenson commented 5 months ago

Thanks. Yes, we typically upgrade when there are major versions or significant minors and patches. Since Lighthouse 12 was released yesterday, I anticipate we will upgrade within a week. I'll update here when I have one.

frederikkempe commented 5 months ago

@adamhenson Sweet. Much appreciated!

adamhenson commented 5 months ago

I started the process of upgrading to Lighthouse 12, but identified what seems to be a bug in which "opportunities" are missing. I opened an issue with the Lighthouse project in https://github.com/GoogleChrome/lighthouse/issues/15977

I've decided to hold until this issue has a response and until PageSpeed Insights has adopted Lighthouse 12.

adamhenson commented 5 months ago

Okay, got a response from Mr. Paul Irish himself in the above issue. Seems like "opportunities" has been missing for a while intentionally, and I just realized we had a function that pulls out that data from deep within the Lighthouse result data. Something in that data has changed which is causing this @foo-software/lighthouse-persist to lose that data when I attempted the version 12 bump. I'm going to get back on it this weekend.

frederikkempe commented 5 months ago

@adamhenson Thanks for your update and persistance!

adamhenson commented 5 months ago

No problem @frederikkempe - thanks for bearing with me.

adamhenson commented 5 months ago

@RhodesPeter @frederikkempe upgrade has been made to use lighthouse@12.0.0 and we're also matching the major versions of this project now with Lighthouse.

You can now use foo-software/lighthouse-check-action@v12.0.0 or foo-software/lighthouse-check-action@latest.

RhodesPeter commented 5 months ago

Thank you!

frederikkempe commented 5 months ago

@adamhenson You're a legend!

adamhenson commented 5 months ago

No problem, thanks again for bearing with me.