search

foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles 🔔 Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
478 stars 24 forks source link

Add link to re-run report against LightHouse when running "locally" locally, in PR comment #34

Closed Vadorequest closed 4 years ago

Vadorequest commented 4 years ago

image

I could use a link close by the url that's been tested with "Run again" text, so that I can run the test again real quick to get a full report.

It could link to either

adamhenson commented 4 years ago

This is a great idea, but instead we could link to our page at https://www.foo.software/lighthouse. We could add query params for url and device to trigger it automatically as soon as that page loads.

Vadorequest commented 4 years ago

Great! This way we could even have shortcuts for each device (one link per device). I assume it's not "too much", and there are only 2 devices available?

adamhenson commented 4 years ago

@Vadorequest - I made an update released in v2.0.5. I don't think we'll be able to support a link that automatically triggers an audit, but we added a "desktop" and "mobile" radio button on the home page. See the comment example in #31

Screen Shot 2020-07-27 at 12 22 13 AM Screen Shot 2020-07-27 at 12 24 07 AM
Vadorequest commented 4 years ago

I believe you meant https://github.com/foo-software/lighthouse-check-action/pull/35 instead of #35

Gonna check this out, thanks for releasing that fast!

Vadorequest commented 4 years ago

@adamhenson https://github.com/UnlyEd/next-right-now/pull/141#commitcomment-40927854 works like a charm

Maybe it'd be interesting to add the ability to customise the Github comment, but that'd be a different need. (point being to add our own urls to the UI)

Or, completely change the layout and rethink the way to present information, to avoid taking so much space and optimise it a bit.

image

I could see a layout where the urls don't take that much space (optimise links when they all share the same base url to highlight the difference instead of using the entire url (e.g: use [/fr](https://xxx/fr) instead of [https://xxx/fr](https://xxx/fr)).

Then, the scores could be part of the table too, as third column.

That would look like this: image

The full base url could be specified above/below only once and save lots of space.

Maybe this alternative layout could become a new option, as it makes a lot of sense when there are many reports to display. (avoid breaking change UI, if that's important)

Or maybe display the url below the scores, since they take so much space anyway, it'd fit and save up some lateral space.

adamhenson commented 4 years ago

Thanks @Vadorequest. I agree - we can re-think the comment layout. I’m not sure I’d want to support custom comments at this time. Omitting the base URL is an interesting idea. There could be other options too. I’ll open a separate issue for that.

adamhenson commented 4 years ago

Created an issue in lighthouse-check since that's where the changes would be made - regarding comment layout. foo-software/lighthouse-check/issues/40