search

foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles 🔔 Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
478 stars 24 forks source link

Minimum Scores not working #53

Closed Mkassabov closed 3 years ago

Mkassabov commented 3 years ago

Minimum scores don't seem to be working. When adding the following job to my workflow:

- name: Handle Lighthouse Check results
  uses: foo-software/lighthouse-check-status-action@master
  with:
    lighthouseCheckResults: ${{ steps.lighthouseCheck.outputs.lighthouseCheckResults }}
    minAccessibilityScore: "90"
    minBestPracticesScore: "50"
    minPerformanceScore: "50"
    minProgressiveWebAppScore: "50"
    minSeoScore: "50"

It returns an error: Error: results.reduce is not a function

Mkassabov commented 3 years ago

I'm dumb and was missing the id value in the main lighthouse check. closing this issue