search

foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles đź”” Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
478 stars 24 forks source link

feature request: retry logic #62

Closed adamhenson closed 2 years ago

adamhenson commented 2 years ago

Summary

For running Lighthouse locally (not against Foo's API), based on #58 - perhaps we could provide retry logic, allowing the user to specify retry count.

Meemaw commented 2 years ago

Hey, are you accepting PRs for this? If you could point me to the relevant code, I could give it a go.

adamhenson commented 2 years ago

Hey @Meemaw - PRs are welcome! However you’d need to do so in this repo which is what this GitHub Action uses under the hood. You’d need to read through the README to figure out how to run it and test… but I could help if needed. You would only need to make this change for “local” runs. The code isn’t the most readable, so it may be a little challenging.

Otherwise, I can make this change within the next week or 2.

Meemaw commented 2 years ago

@adamhenson that would be very much appreciated. I assume its a rather small fix if you know where to look 🙂

adamhenson commented 2 years ago

@Meemaw this feature has been added in v5.1.0. maxRetries is now also reflected in the docs.

Meemaw commented 2 years ago

Muchas gracias 🙏

adamhenson commented 2 years ago

@Meemaw - just a heads up - it seems that this wasn't actually released until just now in v5.1.1.

In v5.1.0 the built code wasn't actually released. Unfortunately, with GitHub Actions - we have to commit the built code and NPM modules. This is a manual step that is often overlooked and was so in this case. In the future I'd like to automate this in CI, but that will require an automated build and commit of the built files which could pose risks.