foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles đź”” Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
478 stars 24 forks source link

Question - Customise slack notification #65

Closed thaiching closed 2 years ago

thaiching commented 2 years ago

Hi, Is it possible to customise the lighthouse metrics data that gets sent to the slack notification rather than using the default slack notification template like this? https://lighthouse-check.s3.amazonaws.com/images/github-actions/github-action-lighthouse-check-slack.png

eg : I would like to include device type and any other extra detailed metrics for each scores in the slack notification. :) Thanks.

adamhenson commented 2 years ago

@thaiching - thanks for raising this issue. I don't think we can support customization at this time, however we should reflect the device in Slack messages. I opened an issue in the lighthouse-check project where this code change will need to happen. See below:

https://github.com/foo-software/lighthouse-check/issues/56

Closing this as it will be addressed in the linked issue above.

adamhenson commented 2 years ago

@thaiching - device type is now included in Slack posts as of v5.1.1.

Thanks for raising this issue.

thaiching commented 2 years ago

Hi Adam, Thank you so much for including the device type into the slack notification. :) That's really useful. If I want to run both the desktop and mobile lighthouse audit check for each url by adding the emulatedFormFactor:all in the circleci config, I'm getting "all" displayed instead of desktop or mobile for each of the url.

Is it possible to display either desktop or mobile for each url in this case? Thank you!

Untitled
adamhenson commented 2 years ago

Hi @thaiching - thanks for reporting… this seems like a valid issue. I should have a fix soon. Re-opening.

adamhenson commented 2 years ago

Hi @thaiching - this issue has now been fixed. Feel free to confirm. Closing again, but let me know if you have further issues

thaiching commented 2 years ago

Hi @adamhenson, it's showing both mobile and desktop now. Thank you so much! :)

adamhenson commented 2 years ago

Perfect, thanks for confirming!