foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles 🔔 Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
480 stars 24 forks source link

GitHub Action device: all should audit mobile and desktop #89

Closed billdevcode closed 2 years ago

billdevcode commented 2 years ago

Not sure if this is a bug or new feature, but I think it's a bug since we're following the documentation. Unless there's a way to get both the mobile and desktop audits using the GitHub Action without using device: 'all'?

Describe the bug A clear and concise description of what the bug is.

To Reproduce Provide examples, configurations, etc. Code does not need to be final or exact, but the closer to being exact - the better.

Expected behavior A clear and concise description of what you expected to happen.

Additional context Add any other context about the problem here.

adamhenson commented 2 years ago

Thanks for reporting this @billdevcode. This is a bug in the documentation really as the intention was to only support this when not running against Foo's API (only when running on a GitHub Runner). Sorry, the docs were wrong.

I believe we can support this however. I'll take a crack at it most likely tomorrow.

adamhenson commented 2 years ago

Hi @billdevcode - this issue is now fixed. Thanks again for reporting. Feel free to confirm or re-open if it doesn't work as you'd expect.