search

foo-software / lighthouse-check-action

GitHub Action for running @GoogleChromeLabs Lighthouse audits with all the bells and whistles 🔔 Multiple audits, Slack notifications, and more!
https://github.com/marketplace/actions/lighthouse-check
MIT License
471 stars 24 forks source link

Report link does not show up on Pull Request #92

Closed emperol2 closed 2 years ago

emperol2 commented 2 years ago

Describe the bug

The Report link does not show up on Pull Request. This might not be a bug but I might misunderstand something.

To Reproduce

image

image

Expected behavior

The report link should show on the table.

Additional context

N/A

Thank you very much 🙇

adamhenson commented 2 years ago

Hello - @emperol2. With this basic configuration there isn't anything to link to. GitHub Artifacts are temporary and even if there was a way to link to them (which I don't think would be straightforward), it wouldn't be sensible based on their ephemeral nature.

To have links show in PRs you have 2 options:

  1. Establish AWS service and create an S3 bucket if you don't have one and follow the example here to add S3 creds.
  2. Sign up and integrate with Foo, so that all results are saved on Foo (to provide a historical timeline). Note in the linked example, you can add respective inputs to get PR comments.

You are correct that this is not a bug and is expected behavior, hence closing. Feel free to confirm the above solution or ask me additional questions here as comments.

emperol2 commented 2 years ago

Thank you very much for this clarification! @adamhenson