search

foo-software / lighthouse-persist

Uploads a Lighthouse report to your AWS S3 account.
12 stars 3 forks source link

Add support for S3 compatible services #4

Open iler opened 4 years ago

iler commented 4 years ago

Would it be possible to add support for other S3 compatible services to upload the reports to? AWS-sdk supports it so it would only require to add support for endpoint directive (https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Endpoint.html) in to this module :)

adamhenson commented 4 years ago

Thanks for the feedback and sorry for the delay. Anything is possible, however I'm personally unfamiliar. Would you want to propose the use case and value?

iler commented 4 years ago

Well then one could use S3 compatible service providers like for example DigitalOcean which offers Spaces as S3 compatible object storage. There are also many other service providers who offer S3 compatible object storage as a service.

adamhenson commented 4 years ago

Thanks @iler. Attempting to support S3 compatible service providers could lead us down a rabbit hole, but I'm open to it - if there could be a way to at least allow the flexibility. I'm not personally familiar with the services and don't have a way to test, so I'd welcome a PR for this one.