search

foo86 / dcadec

DTS Coherent Acoustics decoder with support for HD extensions
117 stars 40 forks source link

Fix specifying compilers and flags #18

Closed TimothyGu closed 9 years ago

TimothyGu commented 9 years ago

Fixes #12. Based on @jamrial's "patch."

Nevcairiel commented 9 years ago

One pull requests changes it to this, another changes it back. You should really finally decide.

IMHO, the current system works just fine. Its a syntax used by many other projects. env vars are ignored for CC/AR, and if you want to override, use "make CC=foo"

TimothyGu commented 9 years ago

IMHO, the current system works just fine. Its a syntax used by many other projects. env vars are ignored for CC/AR, and if you want to override, use make CC=foo

That's the thing that should be improved, and inconsistent with other projects. For example, all autotools projects respect CC etc. environmental variables in the configure stage.

Nevcairiel commented 9 years ago

There is no configure stage here, therefor your argument is invalid. Any Makefile-only projects I know will only take arguments to make when overriding CC or other tools.

foo86 commented 9 years ago

Merged with suggested modification to remove assignments to CC and AR. Thanks.